Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditional trapping of inhibits; assertion; improve Relay NodeID compatibility #2019

Merged
merged 44 commits into from
Apr 11, 2024
Merged

Conditional trapping of inhibits; assertion; improve Relay NodeID compatibility #2019

merged 44 commits into from
Apr 11, 2024

Commits on Apr 10, 2024

  1. Add test of filtering by a nodeId

    @benjie
    benjie committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    6311bea View commit details
    Browse the repository at this point in the history

  2. Add test for filtering by posts with no author

    @benjie
    benjie committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    4edfc4a View commit details
    Browse the repository at this point in the history

  3. Add debugging of output plans and printing of buckets

    @benjie
    benjie committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    938eee9 View commit details
    Browse the repository at this point in the history

  4. docs(changeset): New DEBUG value: grafast:OutputPlan:verbose, print… 

    …s the output plan and the buckets used to produce it to help track down where issues are arising.
    @benjie
    benjie committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    2fe56f9 View commit details
    Browse the repository at this point in the history

  5. Change signature of addDependency such that options contains the step

    @benjie
    benjie committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    fd0915e View commit details
    Browse the repository at this point in the history

  6. Fix subtle change in behavior

    @benjie
    benjie committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    f5b2127 View commit details
    Browse the repository at this point in the history

  7. docs(changeset): 🚨 The step class expression `this.addDependency(step… 

    …, true)` is no longer supported; instead (and equivalently) please use: `this.addDependency({ step, skipDeduplication: true })`. Note `this.addDependency(step)` (with no additional arguments) is unaffected.
    @benjie
    benjie committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    cba8423 View commit details
    Browse the repository at this point in the history

  8. Move deepDepSkip to interfaces

    @benjie
    benjie committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    347d246 View commit details
    Browse the repository at this point in the history

  9. Have getDep build __FlagStep if needed, add getDepOptions

    @benjie
    benjie committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    af38cf9 View commit details
    Browse the repository at this point in the history

  10. Fix circular dependency issue

    @benjie
    benjie committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    1151ec6 View commit details
    Browse the repository at this point in the history

  11. Plans are only peers for deduplication if they have the same flags/on… 

    …Reject
    @benjie
    benjie committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    5972f0d View commit details
    Browse the repository at this point in the history

  12. Added more data to the table

    @benjie
    benjie committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    e5a4ea7 View commit details
    Browse the repository at this point in the history

  13. Update plan diagrams

    @benjie
    benjie committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    68bf558 View commit details
    Browse the repository at this point in the history

  14. Don't re-output copied steps in debug

    @benjie
    benjie committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    1978a82 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Add compare() step

    @benjie
    benjie committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    67c91ed View commit details
    Browse the repository at this point in the history

  2. docs(changeset): Add compare() standard step using lisp-like prefix… 

    … unary and binary operators.
    @benjie
    benjie committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    a5c20fe View commit details
    Browse the repository at this point in the history

  3. Move from a tuple to an object

    @benjie
    benjie committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    2011f3d View commit details
    Browse the repository at this point in the history

  4. Overhaul flag/trap exports

    @benjie
    benjie committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    3ebacd1 View commit details
    Browse the repository at this point in the history

  5. Fix a couple bugs

    @benjie
    benjie committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    f3a8f75 View commit details
    Browse the repository at this point in the history

  6. Trapping is working so we can reject invalid node IDs now... HOORAY!

    @benjie
    benjie committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    90a4579 View commit details
    Browse the repository at this point in the history

  7. Use safe error

    @benjie
    benjie committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    43d21f8 View commit details
    Browse the repository at this point in the history

  8. Test conditional

    @benjie
    benjie committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    b39c37f View commit details
    Browse the repository at this point in the history

  9. Use flags directly, remove instanceof checks

    @benjie
    benjie committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    abe6819 View commit details
    Browse the repository at this point in the history

  10. Update logic slightly

    @benjie
    benjie committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    5754dbc View commit details
    Browse the repository at this point in the history

  11. Improve node descriptions in plan diagram

    @benjie
    benjie committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    d1de037 View commit details
    Browse the repository at this point in the history

  12. Inline more __FlagStep

    @benjie
    benjie committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    5c14982 View commit details
    Browse the repository at this point in the history

  13. Assign UUIDs to internal errors

    @benjie
    benjie committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    5b2340a View commit details
    Browse the repository at this point in the history

  14. Update test snapshots

    @benjie
    benjie committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    faa0c31 View commit details
    Browse the repository at this point in the history

  15. Lint fixes

    @benjie
    benjie committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    032c8a0 View commit details
    Browse the repository at this point in the history

  16. Rename 'compare' to 'condition'

    @benjie
    benjie committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    4ba0bce View commit details
    Browse the repository at this point in the history

  17. Rename operators and add documentation

    @benjie
    benjie committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    f9ba4b5 View commit details
    Browse the repository at this point in the history

  18. Update snapshots with new names

    @benjie
    benjie committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    1af9b47 View commit details
    Browse the repository at this point in the history

  19. docs(changeset): Add conditional trap()-ing functionality, so you c… 

    …an choose to only trap under certain circumstances.
    @benjie
    benjie committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    64ce7b7 View commit details
    Browse the repository at this point in the history

  20. docs(changeset): Now possible to filter by relay node identifiers wit… 

    …hout weird results if you pass an incompatible node id (e.g. a 'Post' ID where a 'User' ID was expected) - significantly improves the Relay preset.
    @benjie
    benjie committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    51a9441 View commit details
    Browse the repository at this point in the history

  21. Demonstrate that undefined also works correctly

    @benjie
    benjie committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    1731391 View commit details
    Browse the repository at this point in the history

  22. Fix moduleName in __FlagStep export

    @benjie
    benjie committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    95d2e86 View commit details
    Browse the repository at this point in the history

  23. Clarify function purpose

    @benjie
    benjie committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    66da0bd View commit details
    Browse the repository at this point in the history

  24. __FlagStep conditional should accept all inputs and filter as appropr… 

    …iate
    @benjie
    benjie committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    2d0a9f5 View commit details
    Browse the repository at this point in the history

  25. Update snapshots

    @benjie
    benjie committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    18bbb8a View commit details
    Browse the repository at this point in the history

  26. Remove incorrect removal of __FlagStep

    @benjie
    benjie committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    c188f06 View commit details
    Browse the repository at this point in the history

  27. Remove unused API

    @benjie
    benjie committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    089e25e View commit details
    Browse the repository at this point in the history

  28. Fix test running to run the new test

    @benjie
    benjie committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    beb75ed View commit details
    Browse the repository at this point in the history

  29. Move comment outside of plan

    @benjie
    benjie committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    52c2803 View commit details
    Browse the repository at this point in the history

  30. Update snapshots

    @benjie
    benjie committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    cf8af9d View commit details
    Browse the repository at this point in the history