Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identifiers selected on totalCount only connection #428

Closed
benjie opened this issue Mar 23, 2019 · 0 comments · Fixed by #429
Closed

Identifiers selected on totalCount only connection #428

benjie opened this issue Mar 23, 2019 · 0 comments · Fixed by #429

Comments

@benjie
Copy link
Member

benjie commented Mar 23, 2019

Regression
@benjie benjie mentioned this issue Mar 25, 2019
Merged
benjie added a commit that referenced this issue Mar 25, 2019
@benjie
fix(connection): don't query identifiers unless necessary (#429)
16785c4 
Connections can be used for aggregates such as `totalCount`. If no nodes/cursors are requested then pulling down identifiers is unnecessary and leads to slower `totalCount` and unnecessary live fields.

This PR stops connection planners from pulling down identifiers and connection resolvers from registering live records, instead leaving that to the parts of the schema (`nodes` / `edges[].node` / `edges[].cursor`) that do require that functionality.

Fixes #428
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(connection): don't query identifiers unless necessary graphile/graphile-engine
1 participant
@benjie