Add getNodeIdFromTypeAndIdentifiers(nodeId) to build #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjie
requested changes
Jul 23, 2018
| @@ -60,6 +67,10 @@ export default (function NodePlugin( | |||
| JSON.stringify([this.getNodeAlias(Type), ...identifiers]) | |||
| ); | |||
| }, | |||
| getTypeAndIdentifiersForNodeId(nodeId) { | |||
There was a problem hiding this comment.
Please rename to getTypeAndIdentifiersFromNodeId
| @@ -13,15 +13,15 @@ export default async function resolveNode( | |||
| $$nodeType, | |||
| parseResolveInfo, | |||
| nodeFetcherByTypeName, | |||
| getTypeAndIdentifiersForNodeId | |||
| getNodeType, | ||
| graphql: { getNamedType }, | ||
| } = build; | ||
| if (nodeId === "query") { | ||
| return $$isQuery; | ||
| } | ||
| try { | ||
| const [alias, ...identifiers] = JSON.parse(base64Decode(nodeId)); | ||
| const Type = getNodeType(alias); | ||
| const { Type, identifiers} = getTypeAndIdentifiersForNodeId(nodeId); |
benjie
reviewed
Jul 23, 2018
| @@ -30,6 +31,12 @@ export type BuildExtensionNode = {| | |||
| Type: GraphQLType, | |||
| ...identifiers: Array<mixed> | |||
| ): string, | |||
| getTypeAndIdentifiersFromNodeId( | |||
| nodeId: GraphQLID | |||
There was a problem hiding this comment.
This is just string here; it's already been parsed from GraphQLID
wieseljonas
changed the title
|
@benjie I think we are good now |
benjie
reviewed
Jul 23, 2018
| @@ -8,10 +8,11 @@ import type { | |||
| } from "../SchemaBuilder"; | |||
| import resolveNode from "../resolveNode"; | |||
| import type { ResolveTree } from "graphql-parse-resolve-info"; | |||
| import type { GraphQLType, GraphQLInterfaceType } from "graphql"; | |||
| import type { GraphQLType, GraphQLID, GraphQLInterfaceType } from "graphql"; | |||
benjie
reviewed
Jul 23, 2018
| @@ -30,6 +31,12 @@ export type BuildExtensionNode = {| | |||
| Type: GraphQLType, | |||
| ...identifiers: Array<mixed> | |||
| ): string, | |||
| getNodeIdFromTypeAndIdentifiers( | |||
| nodeId: GraphQLID | |||
benjie
reviewed
Jul 23, 2018
| @@ -60,6 +67,13 @@ export default (function NodePlugin( | |||
| JSON.stringify([this.getNodeAlias(Type), ...identifiers]) | |||
| ); | |||
| }, | |||
| getNodeIdFromTypeAndIdentifiers(nodeId) { | |||
There was a problem hiding this comment.
Wait; isn't this getTypeAndIdentifiersFromNodeId rather than getNodeIdFromTypeAndIdentifiers
madtibo
pushed a commit
to spacefill/graphile-engine
that referenced
this pull request
Dec 7, 2021
Bumps [prismjs](https://github.com/PrismJS/prism) from 1.21.0 to 1.23.0. - [Release notes](https://github.com/PrismJS/prism/releases) - [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md) - [Commits](PrismJS/prism@v1.21.0...v1.23.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.