Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag to stop LDS loop while no timer is active #756

Closed
wants to merge 3 commits into from
Closed

Flag to stop LDS loop while no timer is active #756

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7bfd7bd
Flag to stop LDS loop while no timer is active
ab-pm Sep 10, 2021
2ca6a7e
Apply suggestions from code review
benjie Sep 10, 2021
02c6c8e
Apply suggestions from code review
benjie Sep 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/lds/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,16 +92,19 @@ export default async function subscribeToLogicalDecoding(
}

let loopTimeout: NodeJS.Timer;
let nextSleepDuration = 0;
benjie marked this conversation as resolved.
Show resolved Hide resolved

const ldSubscription = {
close: async () => {
clearTimeout(loopTimeout);
nextSleepDuration = 0;
benjie marked this conversation as resolved.
Show resolved Hide resolved
await client.close();
},
};

let nextStaleCheck = Date.now() + DROP_STALE_SLOTS_INTERVAL;
async function loop() {
nextSleepDuration = sleepDuration;
benjie marked this conversation as resolved.
Show resolved Hide resolved
try {
const rows = await client.getChanges(null, 500);
benjie marked this conversation as resolved.
Show resolved Hide resolved
if (rows.length) {
Expand Down Expand Up @@ -161,10 +164,11 @@ export default async function subscribeToLogicalDecoding(
} catch (e) {
console.error("Error during LDS loop:", e.message);
// Recovery time...
loopTimeout = setTimeout(loop, sleepDuration * 10);
return;
nextSleepDuration *= 10;
benjie marked this conversation as resolved.
Show resolved Hide resolved
}
if (nextSleepDuration) { // else loop has been stopped
benjie marked this conversation as resolved.
Show resolved Hide resolved
loopTimeout = setTimeout(loop, nextSleepDuration);
}
benjie marked this conversation as resolved.
Show resolved Hide resolved
loopTimeout = setTimeout(loop, sleepDuration);
}
benjie marked this conversation as resolved.
Show resolved Hide resolved
loop();
return ldSubscription;
Expand Down