Cleanup #322
Merged
Cleanup #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d adds more demo examples
…ges, as well as umap-ing. Adds custom edge featurization function. Adds better namespace, and an idempotent way to call featurization. Edge features make sense and produce nice Umaps. Adds initial type checking on main definitons.
…fast setting of new parameters. Last thing left to do is add .plot() with x, y coordinates from UMAP
…t data, and it does a good job.
…ns to include during featurization
…notebooks (not pushed). Adds improvements, with new mixin behaving like graphistry plotter. Featurization works. Only issue now is that the main function call is not idempotent -- g.build_dgl_graph(node_column, y_nodes=y_nodes, y_edges=y_edges, use_node_columns=good_node_columns) throws `IndexingError: Unalignable boolean Series` error. Ill fix tomorrow.
…build_dgl_graph twice -- which was hitting error due to _MASK method, now fixed.
…n we only want to use MLB, with use_cols = [src, dst] only. This forces other_df to be empty, which was throwing errors. Bugs fixed. Adds type checking in umap_utils. DGL tweeks to deal with edata which is still giving errors. Issue is that link prediction uses node data but sums over edges, rather than edge data. Fixing later hopefully
…defaulting to False. If `inplace` will set new attributes to self, returning None. Adds better featurization processors and edge cases. Adds umap().plot() functionality that uses implicit edge dataframe gotten from umap and plots it according to x,y coordinates of umap. Adds functional arguments in .featurize and .umap for better control and user experience. Adds documentation in function calls. Needs tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot!
.umap().featurize().build_dgl_graph()