Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken sync script for rsync v3.1.2 #130

Merged

Conversation

reyjrar
Copy link
Contributor

@reyjrar reyjrar commented Dec 21, 2022

rsync v3.1.2 expects every line in the --from-file to have a newline. Otherwise, it throws an error. This cancels the entire sync.

* Running batch 2401-2700
  - Rsyncing metrics: rsync -azpS --copy-dest="/u2/carbon" --files-from /tmp/tmp1heicu_k carbon@1x.2x.3x.9x:/u2/carbon/ /tmp/1
0.20.36.96dz00hbdq/
ERROR: rejecting unrequested file-list name: whisper/diamond/xxxxxxx/xxxxxx/xxxxxx/memory/SwapFree.wsp
rsync error: protocol incompatibility (code 2) at flist.c(911) [Receiver=3.1.2]
WARNING:root:Failed to sync from carbon@1x.2x.3x.9x:/u2/carbon/! rsync rc=2

rsync v3.1.2 expects every line in the `--from-file` to have a newline.
Otherwise, it throws an error.  This cancels the entire sync.

```
* Running batch 2401-2700
  - Rsyncing metrics: rsync -azpS --copy-dest="/u2/carbon" --files-from /tmp/tmp1heicu_k carbon@1x.2x.3x.9x:/u2/carbon/ /tmp/1
0.20.36.96dz00hbdq/
ERROR: rejecting unrequested file-list name: whisper/diamond/xxxxxxx/xxxxxx/xxxxxx/memory/SwapFree.wsp
rsync error: protocol incompatibility (code 2) at flist.c(911) [Receiver=3.1.2]
WARNING:root:Failed to sync from carbon@1x.2x.3x.9x:/u2/carbon/! rsync rc=2
```
@deniszh deniszh merged commit aa29fdd into graphite-project:master Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants