add identity function #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @Dieterbe, this is straightforward and useful. Can you add this to composer_widgets.js as well? I supposes this would be in the "Special" category |
|
sure, i can do this next week. |
|
i haven't had a chance yet to reference it from composer_widgets.js, and i'm a bit busy lately.. @drawks could you maybe add it? |
|
looking at this again, it seems the Special category doesn't fit well. this is not a function to be applied on a target. it effectively adds a new target with a given name. I'm not sure how to do that in composer_widgets.js |
|
Yeah I think i was wrong to suggest this go in composer_widgets as right now we dont have any functions in there that generated data without a timeseries. This got merged so I think we're good now as is. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.