-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move deserialize into remote finder #2354
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2354 +/- ##
==========================================
- Coverage 79.54% 79.53% -0.02%
==========================================
Files 85 85
Lines 8899 8887 -12
Branches 1901 1899 -2
==========================================
- Hits 7079 7068 -11
+ Misses 1558 1557 -1
Partials 262 262
Continue to review full report at Codecov.
|
just FYI: trying to create simple docker compose to test cluster from 3 nodes |
The tags stuff also uses the finder |
As far as I can tell this is working correctly, any objections to merging it @deniszh ? |
No objections. :) |
This addresses the issue outlined in #2352 by moving the
deserialize
functions into the remote finder and using them infind_nodes
.While this code passes all tests I have not actually tried it yet and would appreciate feedback from anyone who has time to experiment with it.