Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move deserialize into remote finder #2354

Merged
merged 2 commits into from
Oct 22, 2018
Merged

move deserialize into remote finder #2354

merged 2 commits into from
Oct 22, 2018

Conversation

DanCech
Copy link
Member

@DanCech DanCech commented Sep 11, 2018

This addresses the issue outlined in #2352 by moving the deserialize functions into the remote finder and using them in find_nodes.

While this code passes all tests I have not actually tried it yet and would appreciate feedback from anyone who has time to experiment with it.

@codecov-io
Copy link

Codecov Report

Merging #2354 into master will decrease coverage by 0.01%.
The diff coverage is 82.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2354      +/-   ##
==========================================
- Coverage   79.54%   79.53%   -0.02%     
==========================================
  Files          85       85              
  Lines        8899     8887      -12     
  Branches     1901     1899       -2     
==========================================
- Hits         7079     7068      -11     
+ Misses       1558     1557       -1     
  Partials      262      262
Impacted Files Coverage Δ
webapp/graphite/readers/remote.py 100% <100%> (+8.98%) ⬆️
webapp/graphite/finders/remote.py 95.62% <82.5%> (-3.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17e2e1f...6c275a9. Read the comment docs.

@deniszh
Copy link
Member

deniszh commented Sep 16, 2018

just FYI: trying to create simple docker compose to test cluster from 3 nodes

@DanCech
Copy link
Member Author

DanCech commented Sep 17, 2018

The tags stuff also uses the finder request method, so I'm not going to try and shoehorn the de-serialization in there also at the moment.

@DanCech
Copy link
Member Author

DanCech commented Oct 22, 2018

As far as I can tell this is working correctly, any objections to merging it @deniszh ?

@deniszh
Copy link
Member

deniszh commented Oct 22, 2018

No objections. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants