Include tests in PyPI distributions #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @sbraz , |
|
To make it possible to run tests from the PyPI tarballs which are usually cleaner than GitHub's. Gentoo always uses PyPI tarballs over GitHub whenever possible, and I'm pretty sure that's the case for Debian too. I can probably find similar PRs in other projects if you're interested. |
|
No need, thanks! I'm not against it, just curious. :) |
deniszh
approved these changes
May 27, 2018
|
@deniszh I don't know what Python version you use to deploy new releases but you should make sure that everything is included in the MANIFEST. On my system, with Python 3.6, I got the same files as in PyPI's 1.1.3 release, with just the tests added. |
DanCech
approved these changes
May 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, the tests are currently not included in the PyPI tarballs, this PR fixes that.