Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide if auto-include is correct #7

Closed
wagenet opened this issue May 7, 2019 · 3 comments
Closed

Decide if auto-include is correct #7

wagenet opened this issue May 7, 2019 · 3 comments

Comments

@wagenet
Copy link
Collaborator

wagenet commented May 7, 2019

Right now we're auto-including Graphiti code in ActionController::Base source. This may be too aggressive.

First question is whether this has any potential downsides. If so, we should definitely let it be at least configurable. My inclination is to leave it for now and have us be less aggressive if people report issues.
@wagenet wagenet mentioned this issue May 7, 2019
Closed
@wagenet
Copy link
Collaborator Author

wagenet commented May 7, 2019

See also #5 (comment) and #5 (comment)

@richmolj
Copy link
Collaborator

richmolj commented May 9, 2019

Mixin vs Railtie relevant to this one: #10 (comment)

@wagenet
Copy link
Collaborator Author

wagenet commented May 13, 2019

I think with rescue_registry (#22) this is fine.

@wagenet wagenet closed this as completed May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wagenet @richmolj