Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to RescueRegistry #22

Merged
merged 3 commits into from
May 13, 2019
Merged

Switch to RescueRegistry #22

merged 3 commits into from
May 13, 2019

Conversation

wagenet
Copy link
Collaborator

@wagenet wagenet commented May 9, 2019

No description provided.

richmolj
richmolj approved these changes May 10, 2019
View reviewed changes
Copy link
Collaborator

@richmolj richmolj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously some WIP stuff but this is looking really nice, I love the direction you took ❤️

lib/graphiti/rails.rb Show resolved Hide resolved
lib/graphiti/rails/exception_handlers.rb Outdated Show resolved Hide resolved
lib/graphiti/rails/exception_handlers.rb
super.tap do |payload|
payload[:errors][0][:title] = title(error)
class InvalidRequestHandler < ExceptionHandler
# Mostly copied from GraphitiErrors could use some cleanup
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lib/graphiti/rails/railtie.rb Show resolved Hide resolved
spec/dummy/app/controllers/rescue_controller.rb Outdated Show resolved Hide resolved
wagenet
wagenet commented May 10, 2019
View reviewed changes
lib/graphiti/rails.rb Outdated Show resolved Hide resolved
@wagenet wagenet changed the title [WIP] Switch to RescueRegistry Switch to RescueRegistry May 13, 2019
@wagenet wagenet added this to the Release 0.1 milestone May 13, 2019
This was referenced May 13, 2019
Merged
Closed
Closed
Closed
Closed
Closed
@wagenet wagenet merged commit 7f2e38c into master May 13, 2019
@wagenet wagenet deleted the rescue_registry branch May 13, 2019 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richmolj richmolj richmolj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@wagenet @richmolj