Fix initializer autoloading in Rails 7 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing problems when I attempted to upgrade to Rails 7: my `ApplicationController` references some code that doesn't get loaded until Rails has been initialized, and this engine was attempting to load `ApplicationController` before Rails is initialized. This resulted in the code not being found. Wrapping it in a `to_prepare` block fixed the problem. This also fixes a Rubocop being disabled and not re-enabled afterward.
|
@m1foley Unfortunately, I've changed jobs and no longer am working on this project. It seems like possibly no one else is either. If you or anyone else have interest in taking ownership, please let me know. |
|
Thanks. I am no longer using this project, so I wouldn't be a good maintainer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing problems when I attempted to upgrade to Rails 7: my
ApplicationControllerreferences some code that doesn't get loaded until Rails has been initialized, and this engine was attempting to loadApplicationControllerbefore Rails is initialized. This resulted in the code not being found. Wrapping it in ato_prepareblock fixed the problem. I think this wasn't an issue in Rails 6 because the Zeitwork autoloader is strictly enforced in Rails 7.This also fixes a Rubocop being disabled and not re-enabled afterward.