Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up GraphViz class #14

Open
clue opened this issue Jun 29, 2015 · 3 comments
Open

Split up GraphViz class #14

clue opened this issue Jun 29, 2015 · 3 comments
Assignees
Milestone

Comments

@clue
Copy link
Member

clue commented Jun 29, 2015

The current GraphViz class used to be god class that encapsulated all GraphViz-related functionality. This was okay where this class originated (as part of the clue/graph package).

Now that this is a separate package, we should split this up into more discrete parts with a single responsibility each. The existing Image and Dot classes are a first step into this direction (though a badly named and documented one).

This ticket serves as a reminder and as a heads up.

Also refs #2.

@clue clue self-assigned this Jun 29, 2015
@clue
Copy link
Member Author

clue commented Jun 29, 2015

For the reference: I've started looking into this a few months ago and the results did look promising. Unfortunately I've had to pause this due to changed priorities for now.

@clue clue added this to the v0.3.0 milestone Oct 9, 2018
@clue clue added the BC break label Oct 9, 2018
@clue clue modified the milestones: v0.3.0, v0.4.0 Oct 9, 2018
@clue clue modified the milestones: v0.4.0, v1.0.0 Oct 4, 2019
@llaville
Copy link

llaville commented Sep 28, 2020

Hello @clue
What do you think to raise PHP minimum requirements to 5.4
That will allows to use php trait feature to reorganize code and allows more inheritance and change internal code. See article https://andy-carter.com/blog/overriding-extending-a-php-trait-method
I tell that because I d like to integrate cluster support in a more easy way than forking and sync my copy to solve #42
What do think about it

@clue
Copy link
Member Author

clue commented Jan 25, 2021

@llaville It's an interesting thought, but I don't think this is related to this ticket? I'm not a big fan of using a trait here, but perhaps you can file a dedicated ticket to discuss this in more detail?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants