Improve subgraph support #23
Conversation
Add ability to add subgraphs alongside ungrouped vertices
|
What could be done to get this merged? I need the feature too. |
|
@phyrwork Thank you for working on this and filing this PR! I agree that this feature makes perfect sense 👍 That being said, I think this is something that will need a bigger changeset as it is somewhat related to #8 and #13 and also graphp/graph#114. There are plans to remove the "group" property altogether, at which point it makes perfect sense to assign custom "subgraph" attributes. As such, I would like to postpone this for now and have just assigned this to the v0.4.0 milestone. What do you think about this? 👍 |
|
I'm having to close this for now as it hasn't received any input in a while and it's unlikely this will get traction any time soon. Please come back with more details if you think this is still relevant and we can reopen this 👍 Thank you for your effort nonetheless, keep it up! 👍 For a follow-up, see also #23. |
Add ability to add subgraphs alongside ungrouped vertices
Create graphs that look like this (created with this revision)
Requires Vertex::group to be nullable to get this effect (I don't see any reason why a Vertex cannot be groupless
Until then implementation will continue to function as usual (either all subgraphs or no subgraphs)