Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: subgraph migration to L2 sending only the owner's tokens (OZ M-01) #764

Merged
merged 9 commits into from
Mar 3, 2023

Conversation

pcarranzav
Copy link
Member

Building on #585 but only sending the owner's signal and allowing curators to send to L2 or withdraw.

Still studying both options, and pending GIP.

@pcarranzav pcarranzav changed the base branch from dev to pcv/gns-migration-timeout December 15, 2022 15:00
@pcarranzav pcarranzav force-pushed the pcv/l2-gns-migration-owner-only branch 2 times, most recently from 4d5dc9c to 721d463 Compare December 21, 2022 14:50
@pcarranzav pcarranzav changed the base branch from pcv/gns-migration-timeout to pcv/gns-migration-n11-long-calls December 21, 2022 14:56
@pcarranzav pcarranzav force-pushed the pcv/l2-gns-migration-owner-only branch from 721d463 to 4c1b3ea Compare December 21, 2022 21:06
@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (b59c798) 93.41% compared to head (192aecf) 93.42%.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           pcv/l2-gns-migration     #764   +/-   ##
=====================================================
  Coverage                 93.41%   93.42%           
=====================================================
  Files                        46       46           
  Lines                      2249     2252    +3     
  Branches                    404      401    -3     
=====================================================
+ Hits                       2101     2104    +3     
  Misses                      148      148           
Flag Coverage Δ
unittests 93.42% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contracts/discovery/L1GNS.sol 100.00% <100.00%> (ø)
contracts/l2/curation/L2Curation.sol 100.00% <100.00%> (ø)
contracts/l2/discovery/L2GNS.sol 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pcarranzav pcarranzav force-pushed the pcv/l2-gns-migration-owner-only branch 2 times, most recently from 6ed9b89 to b53a0fd Compare December 23, 2022 15:09
@pcarranzav pcarranzav marked this pull request as ready for review December 23, 2022 15:10
@pcarranzav pcarranzav changed the title (WIP/experimental) Alternative approach for migration of subgraphs to L2 feat: subgraph migration to L2 sending only the owner's tokens (OZ M-01) Jan 24, 2023
@pcarranzav pcarranzav changed the title feat: subgraph migration to L2 sending only the owner's tokens (OZ M-01) feat: subgraph migration to L2 sending only the owner's tokens (OZ M-01) - needs audit Jan 24, 2023
@pcarranzav pcarranzav force-pushed the pcv/l2-gns-migration-owner-only branch from b53a0fd to 18eb0a2 Compare January 24, 2023 15:32
Base automatically changed from pcv/gns-migration-n11-long-calls to pcv/l2-gns-migration February 1, 2023 20:44
@pcarranzav pcarranzav changed the title feat: subgraph migration to L2 sending only the owner's tokens (OZ M-01) - needs audit feat: subgraph migration to L2 sending only the owner's tokens (OZ M-01) Feb 7, 2023
contracts/l2/discovery/IL2GNS.sol Show resolved Hide resolved
contracts/discovery/L1GNS.sol Outdated Show resolved Hide resolved
contracts/discovery/L1GNS.sol Outdated Show resolved Hide resolved
contracts/discovery/L1GNS.sol Show resolved Hide resolved
pcarranzav and others added 2 commits February 15, 2023 18:32
@pcarranzav pcarranzav merged commit 192aecf into pcv/l2-gns-migration Mar 3, 2023
2 checks passed
@pcarranzav pcarranzav deleted the pcv/l2-gns-migration-owner-only branch March 3, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants