feat: stake and delegation transfer tools for L2 #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcarranzav
force-pushed
the
pcv/l2-gns-migration-owner-only
branch
from
b53a0fd
to
18eb0a2
Compare
pcarranzav
force-pushed
the
pcv/l2-stake-migration
branch
2 times, most recently
from
74cfbfa
to
fa0f97e
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #786 +/- ##
==========================================
+ Coverage 93.53% 94.44% +0.91%
==========================================
Files 44 49 +5
Lines 2257 2429 +172
Branches 401 436 +35
==========================================
+ Hits 2111 2294 +183
+ Misses 146 135 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
pcarranzav
commented
Jan 31, 2023
pcarranzav
force-pushed
the
pcv/l2-stake-migration
branch
from
f461fa3
to
3bce7f9
Compare
pcarranzav
changed the title
pcarranzav
force-pushed
the
pcv/l2-stake-migration
branch
from
e5e0eff
to
ed02752
Compare
pcarranzav
force-pushed
the
pcv/l2-stake-migration
branch
from
41419b2
to
4325579
Compare
pcarranzav
force-pushed
the
pcv/l2-stake-migration
branch
from
4325579
to
83fffa3
Compare
Base automatically changed from
pcv/l2-gns-migration-owner-only
to
pcv/l2-gns-migration
March 3, 2023 19:58
pcarranzav
added a commit
that referenced
this pull request
Apr 12, 2023
…sion fee (OZ M-01 for #786)
…is received (OZ M-03)
…Z M-07) Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
…o shares (OZ M-09)
abarmat
reviewed
May 2, 2023
| require(_amount >= __minimumIndexerStake, "!minimumIndexerStake sent"); | ||
| } | ||
| // Ensure minimum stake | ||
| indexerStake.tokensStaked = indexerStake.tokensStaked.sub(_amount); |
There was a problem hiding this comment.
I think we could use indexerStake.release(_amount) here but it's fine
abarmat
reviewed
May 3, 2023
| tokensDelegatedCap | ||
| ); | ||
| require( | ||
| indexerStake.tokensUsed() <= indexerStake.tokensStaked.add(tokensDelegatedCapacity), |
There was a problem hiding this comment.
Thinking this might be replaced by getIndexerCapacity(_indexer) > 0
pcarranzav
changed the title
abarmat
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See GIP-0046: https://forum.thegraph.com/t/gip-0046-l2-migration-helpers/4023