fix: override type in CLI to allow wrapping contract calls #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maikol
previously approved these changes
Jan 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #911 +/- ##
=======================================
Coverage 92.69% 92.69%
=======================================
Files 46 46
Lines 2369 2369
Branches 426 426
=======================================
Hits 2196 2196
Misses 173 173
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tmigone
requested changes
Jan 11, 2024
|
Btw this code duplication problem should be resolved once we get rid of the cli folder. |
tmigone
previously approved these changes
Jan 12, 2024
| @@ -66,7 +71,7 @@ export function wrapCalls(contract: Contract, contractName: string): Contract { | |||
| wrappedContract.functions[fn] = override | |||
There was a problem hiding this comment.
We should remove:
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
pcarranzav
force-pushed
the
pcv/fix-cli-wrapcalls
branch
from
bb98512
to
78bb79f
Compare
tmigone
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.