Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove cli from protocol contracts #914

Merged
merged 14 commits into from
Jan 15, 2024
Merged

chore: remove cli from protocol contracts #914

merged 14 commits into from
Jan 15, 2024

Conversation

tmigone
Copy link
Contributor

@tmigone tmigone commented Jan 12, 2024

Changes

  • Remove CLI from the project
  • Add contract deploy hardhat task

There are a few other cli commands that don't exist as hardhat tasks but I don't think we use them. I'd rather only migrate them if/when we need them.

@tmigone tmigone changed the title feat: remove cli from protocol contracts chore: remove cli from protocol contracts Jan 12, 2024
@tmigone tmigone changed the base branch from main to tmigone/deploy-consolidate January 12, 2024 15:32
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone tmigone marked this pull request as ready for review January 12, 2024 16:26
Maikol
Maikol previously approved these changes Jan 15, 2024
Copy link
Member

@Maikol Maikol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Base automatically changed from tmigone/deploy-consolidate to main January 15, 2024 18:37
@tmigone tmigone dismissed Maikol’s stale review January 15, 2024 18:37

The base branch was changed.

@tmigone tmigone merged commit ee324fa into main Jan 15, 2024
5 of 6 checks passed
@tmigone tmigone deleted the tmigone/delete-cli branch January 15, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants