Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gre): several improvements #917

Merged
merged 20 commits into from
Jan 15, 2024
Merged

feat(gre): several improvements #917

merged 20 commits into from
Jan 15, 2024

Conversation

tmigone
Copy link
Contributor

@tmigone tmigone commented Jan 15, 2024 •
edited

Changes

  • Allow setting address book via hardhat config
  • Fix deploy yarn task
  • Fix tx logging and enable it by default

Tx logging output sample:

[2024-01-15T14:27:41.737Z] > Deploying contract: AllocationExchange
[2024-01-15T14:27:41.737Z]    = Sender: 0x90F8bf6A479f320ead074411a4B0e7944Ea8c9C1
[2024-01-15T14:27:41.737Z]    = Params: [ 0x64d2ec8fA603B3Ad18b7a4529bDae42064994953,0xf454f24A62E5Be73aA877Aa824b78F8F2a31d236,0x3E5e9111Ae8eB78Fe1CC3bb8915d5D461F3Ef9A9,0xE11BA2b4D45Eaed5996Cd0823791E0C93114882d ]
[2024-01-15T14:27:41.737Z]    = TxHash: 0xfabd2bc05bd3fb9a9939b220d448fa3b291eb98899bbcc3ba0e1d197a0473899
[2024-01-15T14:27:41.742Z]    = CreationCodeHash: 0x8cb1e23d5966a0aed4efe43c3c2c8ff45adbcd0dbbc84f13f1a19882264af8be
[2024-01-15T14:27:41.742Z]    = RuntimeCodeHash: 0xa05a0db27cadb1b742afc1662f63fbd9dd4ae2907d6cdc453fd689dd811b6474
[2024-01-15T14:27:41.742Z]    ✔ Transaction succeeded!
...
[2024-01-15T14:35:09.618Z] > Sending transaction: GraphToken.approve
[2024-01-15T14:35:09.618Z]    = Sender: 0x855FA758c77D68a04990E992aA4dcdeF899F654A
[2024-01-15T14:35:09.618Z]    = Contract: 0x6eD79Aa1c71FD7BdBC515EfdA3Bd4e26394435cC
[2024-01-15T14:35:09.618Z]    = Params: [ 0xD86C8F0327494034F60e25074420BcCF560D5610,2000000000000000000000 ]
[2024-01-15T14:35:09.618Z]    = TxHash: 0x82605edad7d44821a6d36736d672d9ed1321eae227b9f268fcd8ff34a7d7b1fa
[2024-01-15T14:35:09.621Z]    ✔ Transaction succeeded!
[2024-01-15T14:35:09.659Z] > Sending transaction: L1GNS.mintSignal
[2024-01-15T14:35:09.659Z]    = Sender: 0x855FA758c77D68a04990E992aA4dcdeF899F654A
[2024-01-15T14:35:09.659Z]    = Contract: 0xD86C8F0327494034F60e25074420BcCF560D5610
[2024-01-15T14:35:09.659Z]    = Params: [ 0xa3db9b6abfa65357fef65227802585861000c28566b2790721a9639471bda465,2000000000000000000000,0,[object Object] ]
[2024-01-15T14:35:09.659Z]    = TxHash: 0xd98127313d628ee34ae0a623828ccabdc4fd4849185c24ec5db24993e12adde3
[2024-01-15T14:35:09.662Z]    ✔ Transaction succeeded!

@tmigone
test: move unit tests to a new folder
ef587db 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
test: move e2e tests to test folder
aeb5de9 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
test: revert address book changes
53bf089 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
test: fix e2e tests bridge exlusion
b7211bd 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
fix: ensure hh test only runs unit tests
4a89923 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
test: fix unit test type import paths
516a813 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
chore: simplify protocol deployment scripts
fbe6730 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
test: use sdk for deploy and post deploy
d13a08a 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
test: l1 tests pass
1dc3e9a 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
test: l2 tests passing
7fda79a 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
chore: bump package versions
7221dad 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
fix: hh migrate task
0efbe25 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
chore: remove cli from project 💥
69c6483 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
chore: use graphTask for hardhat tasks
2bc2a5b 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
chore: rename graphTask to greTask
eac5fa4 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
test: fix e2e task parsing values
d5daa0f 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
feat(gre): allow configuring address book via hardhat network config
4951ea4 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
feat(gre): fix tx logging and enable by default
43036eb 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Maikol
Maikol reviewed Jan 15, 2024
View reviewed changes
packages/sdk/src/deployments/network/actions/governed.ts Outdated
@@ -33,6 +33,8 @@ export const acceptOwnership: GraphNetworkAction<
console.log(`No pending governor for ${contract.address}`)
return
}
console.log(pendingGovernor)
console.log(signer.address)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these logs needed? Looks like debugging leftovers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

@tmigone
fix: remove unneeded console logs
6064a11 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Maikol
Maikol previously approved these changes Jan 15, 2024
View reviewed changes
Base automatically changed from tmigone/gre-task to main January 15, 2024 18:58
@tmigone tmigone dismissed Maikol’s stale review January 15, 2024 18:58

The base branch was changed.

@tmigone tmigone merged commit 0352cdc into main Jan 15, 2024
4 of 6 checks passed
@tmigone tmigone deleted the tmigone/gre-improvements branch January 15, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maikol Maikol Maikol approved these changes

@pcarranzav pcarranzav Awaiting requested review from pcarranzav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tmigone @Maikol