chore: update token-distribution to use our linting packages #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@changesets/cli@2.27.1, npm/@commitlint/cli@18.6.1, npm/@commitlint/config-conventional@18.6.2, npm/husky@8.0.3 |
chore: update token-distribution to use our linting packages
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
pcarranzav
previously approved these changes
Feb 28, 2024
| @@ -324,7 +325,8 @@ describe('GraphTokenLockSimple', () => { | |||
| // Before cliff no vested tokens | |||
| if (cliffTime.gt(0) && currentTime.lt(cliffTime)) { | |||
| expectedAmount = BigNumber.from(0) | |||
| } else { | |||
| } | |||
| else { | |||
There was a problem hiding this comment.
This looks like a weird choice for linter output doesn't it? } else { looked cleaner imo, not sure if that's configurable
There was a problem hiding this comment.
yeah i actually agree with you, going to look into it, I didn't notice this.
tmigone
dismissed stale reviews from pcarranzav and Maikol
The base branch was changed.
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Maikol
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.