-
Notifications
You must be signed in to change notification settings - Fork 962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tendermint integration #3212
Tendermint integration #3212
Conversation
* TendermintTrigger variant fields are generated by prost and don't implement PartialOrd * need to rely on the Ord impl
@patiee @pienkowb I remember that you folks mentioned that you might be able to use the direct If we're keeping this one, I've answered all comments and resolved the ones that nothing should be done about 🙂 |
We're still experimenting with importing the official |
GRAPH-139 refactoring from PR (graphprotocol/graph-node#3212) reviews
* add dynamic data sources error
Remove abi and address from Source
* to filter handler events by origin as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Congrats 👏
@pienkowb the unit tests are failing, can you double check why that is? |
@otaviopace I'm checking it. BTW, we might want to clean up the commit history before merging. |
We can just squash them 🙂 |
@pienkowb the tests are failing because of arguments that changed in some parts of the codebase |
@otaviopace The tests are passing now :) +1 for squashing the commits into one. |
No description provided.