Fix writing and loading of dynamically created data sources #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Jannis
force-pushed
the
jannis/fix-dynamic-data-sources-loading
branch
from
1e65427
to
90f1d0f
Compare
ghost
approved these changes
May 2, 2019
|
We should get a macro for deriving these things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two problems:
When writing dynamic data sources entities to the store, the mapping entity was missing. This caused dynamic data sources loading on restarts to fail.
There was a typo in the code that parses a mapping entity back from a GraphQL value. This would also cause dynamic data sources to not load correctly.