refactor: move to typescript, drop eslint and use prettier for linting, fix linting issues #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 954cee6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
enisdenjo
changed the title
enisdenjo
approved these changes
Jan 12, 2023
saihaj
commented
Jan 13, 2023
| let conversions = TYPE_CONVERSIONS.getIn([fromTypeSystem, toTypeSystem]) | ||
| if (conversions === undefined) { | ||
| if (conversions == undefined) { |
There was a problem hiding this comment.
maybe we should keep this one? maybe it was trying to account for all falsy values?
There was a problem hiding this comment.
It was strictly checking for undefined previously. I've reverted the change just to reduce the changeset (and keep the bugs away).
See here: 954cee6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
anyto expedite the process