-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: record query metrics #39
Conversation
480ed16
to
5ad05b7
Compare
Pull Request Test Coverage Report for Build 5967540548
💛 - Coveralls |
5ad05b7
to
b6ca415
Compare
🤔 shouldn't the query duration be discarded if there's an error? I don't know what the choice was in the original indexer-service though. |
And I also have similar question about |
The typescript version uses the syntax
FAILED_QUERIES seems to be recorded for when query_processor fails to execute a paid query (ts version) |
Yup I see, thanks for the pointers, yours indeed behaves like the original. IMO the original is wrong though 😬 . |
I agree with you 😂 We can change it up later, will add a note to the metrics tracking issue #4 |
Track query volume and performance like the original indexer service.
Some metrics from the original are registered but not used so they are not included here
Part of #4
For later: Add cost model metrics once there is cost server