Allow cost models in single network mode #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`multiNetworks` was erroneously typed as possibly `undefined`, and `undefined` was used as a way to determine if we are in multi or single network mode in `cost-models.ts`. However, the code doesn't actually allow for `multiNetworks` to be undefined, be it in multi or single network mode. Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
…settings Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
|
Oops should have run |
Check for undefined and fail in cost models. Since `setCostModel` is only run by indexer-agent, and indexer-agent must have a network defined. Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
aasseman
changed the title
dwerner
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multiNetworkswas erroneously typed as possiblyundefined, andundefinedwas used as a way to determine if we are in multi or single network mode incost-models.ts.However, the code doesn't actually allow for
multiNetworksto be undefined, be it in multi or single network mode.Some of these changes should be inconsequential considering the impending deprecation of Ethereum mainnet, as well as the fact that most indexers stopped using cost models due in part to #789.
Fixes #789