Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for customExecuteFn #138

Merged
merged 1 commit into from
Jul 24, 2021

Conversation

dios-david
Copy link
Contributor

@dios-david dios-david commented Nov 30, 2020

Hello! I'm using koa-graphql for almost a year now without any issues so far.
Recently I heard about graphql-jit and I want to experiment with it in my GraphQL server, but unfortunately koa-graphql doesn't support the customExecuteFn option which is needed to integrate graphql-jit.

As this project is a port of express-graphql which has the support for customExecuteFn, I made the required changes based on the implementation in express-graphql.

Let me know if there is anything needs to be changed!

@dios-david
Copy link
Contributor Author

Hey @MaxDesiatov I'm not sure who to ping, but I saw the last merge was yours, so.. :) Can you please check this PR?

@MaxDesiatov
Copy link
Contributor

Strictly speaking, I'm not a maintainer of this project to review PRs of this type. Maybe @chentsulin could help?

Copy link
Contributor

@sibelius sibelius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about just execute?

have you heard of helix (https://github.com/contrawork/graphql-helix) it is more versatile than koa-graphql

@dios-david
Copy link
Contributor Author

Thanks @sibelius Helix definitely looks interesting, I will try that thanks for the heads up.
Currently I'm just looking for the simplest solution to integrate graphql-jit with my current setup, but in long term maybe migrating to something more complex (like Helix) would be a good idea.

@glen-84
Copy link

glen-84 commented Dec 17, 2020

@chentsulin Is this project no longer maintained?

@chentsulin chentsulin merged commit 904bae0 into graphql-community:master Jul 24, 2021
@chentsulin
Copy link
Member

Thanks, that's a good addition. Sorry for the late reply. I will release a new version soon.

@chentsulin
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants