Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retarget System.Text.Json to netcoreapp3.1 #2035

Merged
merged 1 commit into from
Dec 5, 2020
Merged

Retarget System.Text.Json to netcoreapp3.1 #2035

merged 1 commit into from
Dec 5, 2020

Conversation

sungam3r
Copy link
Member

@sungam3r sungam3r commented Dec 4, 2020 

Warning	NETSDK1138	The target framework 'netcoreapp3.0' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.	GraphQL.SystemTextJson	C:\Program Files\dotnet\sdk\5.0.100\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.EolTargetFrameworks.targets	28

изображение

I suggest that we just change the patch version. GraphQL.SystemTextJson is already multitargeted for netstandard2.0 so even old clients (netcoreapp3.0 as well) can continue to consume its bits.

@github-actions github-actions bot added performance Issue or pull request about performance problems test Pull request that adds new or changes existing tests labels Dec 4, 2020
@sungam3r sungam3r removed performance Issue or pull request about performance problems test Pull request that adds new or changes existing tests labels Dec 4, 2020
@sungam3r sungam3r requested a review from Shane32 December 4, 2020 21:05
@sungam3r sungam3r merged commit b64c4ae into master Dec 5, 2020
@sungam3r sungam3r deleted the netcore31 branch December 5, 2020 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shane32 Shane32 Shane32 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sungam3r @Shane32