Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert solution to file-scoped namespaces #168

Merged
merged 2 commits into from
Jan 8, 2022
Merged

Convert solution to file-scoped namespaces #168

merged 2 commits into from
Jan 8, 2022

Conversation

sungam3r
Copy link
Member

@sungam3r sungam3r commented Jan 8, 2022

@github-actions github-actions bot added code style Pull request that applies code style rules performance test Pull request that adds new or changes existing tests labels Jan 8, 2022
@sungam3r sungam3r removed performance test Pull request that adds new or changes existing tests labels Jan 8, 2022
@github-actions github-actions bot added performance test Pull request that adds new or changes existing tests labels Jan 8, 2022
@sungam3r
Copy link
Member Author

sungam3r commented Jan 8, 2022

@Shane32 I'll merge this ASAP, I changed only namespaces, no other changes.

@sungam3r sungam3r removed performance test Pull request that adds new or changes existing tests labels Jan 8, 2022
@sungam3r sungam3r added this to the 8.0 milestone Jan 8, 2022
@sungam3r sungam3r self-assigned this Jan 8, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #168 (56bdce8) into master (a32b806) will not change coverage.
The diff coverage is 80.43%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #168   +/-   ##
=======================================
  Coverage   86.98%   86.98%           
=======================================
  Files          83       83           
  Lines        4088     4088           
  Branches      388      388           
=======================================
  Hits         3556     3556           
  Misses        488      488           
  Partials       44       44           
Impacted Files Coverage Δ
src/GraphQLParser/ParserContext.Parse.cs 96.96% <ø> (ø)
src/GraphQLParser/Visitors/SDLWriter.cs 92.08% <ø> (ø)
src/GraphQLParser/Visitors/StructureWriter.cs 95.65% <ø> (ø)
...c/GraphQLParser/Visitors/WriteContextExtensions.cs 100.00% <ø> (ø)
src/GraphQLParser/AST/GraphQLArguments.cs 22.22% <22.22%> (ø)
...rc/GraphQLParser/AST/GraphQLArgumentsDefinition.cs 22.22% <22.22%> (ø)
...c/GraphQLParser/AST/GraphQLEnumValuesDefinition.cs 22.22% <22.22%> (ø)
src/GraphQLParser/AST/GraphQLFieldsDefinition.cs 22.22% <22.22%> (ø)
...c/GraphQLParser/AST/GraphQLImplementsInterfaces.cs 22.22% <22.22%> (ø)
.../GraphQLParser/AST/GraphQLInputFieldsDefinition.cs 22.22% <22.22%> (ø)
... and 89 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a32b806...56bdce8. Read the comment docs.

@sungam3r sungam3r merged commit 5aed200 into master Jan 8, 2022
@sungam3r sungam3r deleted the file-scoped branch January 8, 2022 10:33
@sungam3r
Copy link
Member Author

sungam3r commented Jan 8, 2022

It seems that CodeQL doesn't understand file-scoped namespaces github/codeql#7544

@Shane32
Copy link
Member

Shane32 commented Jan 8, 2022

So … does that mean this PR needs to be reverted?

@sungam3r
Copy link
Member Author

sungam3r commented Jan 8, 2022

No. CodeQL workflow works and green. Waiting for answer from CodeQL team. At least now we know about such issue 👍 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code style Pull request that applies code style rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants