-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert solution to file-scoped namespaces #168
Conversation
@Shane32 I'll merge this ASAP, I changed only namespaces, no other changes. |
Codecov Report
@@ Coverage Diff @@
## master #168 +/- ##
=======================================
Coverage 86.98% 86.98%
=======================================
Files 83 83
Lines 4088 4088
Branches 388 388
=======================================
Hits 3556 3556
Misses 488 488
Partials 44 44
Continue to review full report at Codecov.
|
It seems that CodeQL doesn't understand file-scoped namespaces github/codeql#7544 |
So … does that mean this PR needs to be reverted? |
No. CodeQL workflow works and green. Waiting for answer from CodeQL team. At least now we know about such issue 👍 . |
Thanks to .editorconfig: https://stackoverflow.com/questions/69889519/vs-2022-convert-to-file-scoped-namespace-in-all-files