-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize location conversion #202
Conversation
/// <br/> | ||
/// <br/><br/> | ||
/// This struct is designed to unify work with objects of <see cref="ReadOnlyMemory{T}"/>, | ||
/// <see cref="ReadOnlySpan{T}"/> ans <see cref="string"/>. For example, you can directly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shane32 I added these notes to make ROM usage by other projects more understandable.
Example:
|
I'll add tests for 100% coverage later, 3:30AM here. |
The desire to get full coverage again made it possible to find a bug. |
Codecov Report
@@ Coverage Diff @@
## master #202 +/- ##
=======================================
Coverage 98.75% 98.76%
=======================================
Files 85 85
Lines 4411 4438 +27
Branches 434 437 +3
=======================================
+ Hits 4356 4383 +27
Misses 33 33
Partials 22 22
Continue to review full report at Codecov.
|
I spent on writing and debugging this algorithm a bunch of time. Although this code is performed only when making exception messages, I wanted to get rid of the regular expression. No memory allocations at all now. If you check code before changes on a rather big query, then you will make sure that the work with a regular expression here generates an abnormal amount of memory allocations.
fixes #102