Optimize WriteEncodedStringAsync #216
Conversation
| await context.WriteAsync("\\\"").ConfigureAwait(false); | ||
| else | ||
| await context.WriteAsync(value.Slice(i, 1)/*code*/).ConfigureAwait(false); // TODO: no method for char |
There was a problem hiding this comment.
Hot path: await + one-symbol slicing
@Shane32 We should use the same approach for comments/block strings
There was a problem hiding this comment.
So now in case of "normal" strings this loop does nothing just incrementing counter - single write is done at the end of method:
await context.WriteAsync(value.Slice(startIndexOfNotEncodedString, value.Span.Length - startIndexOfNotEncodedString)).ConfigureAwait(false);
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
==========================================
- Coverage 98.96% 98.91% -0.05%
==========================================
Files 84 84
Lines 4424 4439 +15
Branches 428 432 +4
==========================================
+ Hits 4378 4391 +13
- Misses 29 30 +1
- Partials 17 18 +1
Continue to review full report at Codecov.
|
github-actions
bot
added
the
test
|
I merge this and go on. |
Should be much faster in majority of cases.