Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for anonymous contained structs #274

Closed
wants to merge 2 commits into from
Closed

Support for anonymous contained structs #274

wants to merge 2 commits into from

Conversation

Oscil8
Copy link

@Oscil8 Oscil8 commented Jan 30, 2018

These should behave similarly to the equivalent case in
https://golang.org/pkg/encoding/json/

Ariel Salomon added 2 commits January 29, 2018 22:37
Add test for fields in an anonymous contained struct
0861000 
These should behave similarly to the equivalent case in
https://golang.org/pkg/encoding/json/
Implement support for anonymous contained structs by extracting
459c4e2 
defaultResolveStruct from DefaultResolveFn
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 81.045% when pulling 459c4e2 on Oscil8:anon-contained-struct into 1c504cf on graphql-go:master.

1 similar comment
@coveralls
Copy link

coveralls commented Jan 30, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 81.045% when pulling 459c4e2 on Oscil8:anon-contained-struct into 1c504cf on graphql-go:master.

@chris-ramon
Copy link
Member

chris-ramon commented Jul 28, 2018 •
edited
Loading

Thanks a lot @Oscil8! closing this one in favor of: #371 — git cherry-picked the commits.

@chris-ramon chris-ramon mentioned this pull request Oct 24, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Oscil8 @coveralls @chris-ramon