Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace len(x)<=v with len(x)==v #374

Merged
merged 2 commits into from Jul 28, 2018
Merged

replace len(x)<=v with len(x)==v #374

merged 2 commits into from Jul 28, 2018

Conversation

quasilyte
Copy link
Contributor

Length can't be negative, so use more appropriate operator.

Found using https://go-critic.github.io/overview#sloppyLen-ref

Length can't be negative, so use more appropriate operator.

Found using https://go-critic.github.io/overview#sloppyLen-ref
@coveralls
Copy link

coveralls commented Jul 28, 2018

Coverage Status

Coverage remained the same at 91.919% when pulling da5511a on Quasilyte:sloppyLen into 8bad5f4 on graphql-go:master.

@chris-ramon
Copy link
Member

LGTM 👍 — thanks a lot @quasilyte!

@chris-ramon chris-ramon merged commit 657726d into graphql-go:master Jul 28, 2018
@quasilyte quasilyte deleted the sloppyLen branch July 28, 2018 20:35
@quasilyte
Copy link
Contributor Author

@chris-ramon thanks for warm comments. ^^
Really makes these contributing sessions enjoyable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants