javax.servlet -> jakarta.servlet:6.0

[eduarddrenth]

updated dependencies to jakarta
updated groovy accordingly
renamed javax to jakarta

[eduarddrenth]

tested this PR on one of my applications, runs fine on payara 6.2022.1 / ee 10

[eduarddrenth]

fixes #484

[eduarddrenth]

build pipeline needs to support class version 55, run jdk 11

[oliemansm]

@eduarddrenth That would mean that from this version on Java 8 would no longer be supported by this library. MIght be a good moment as any to do it.

[eduarddrenth]

A metter of changing gradle.properties?

SOURCE_COMPATIBILITY=1.8
TARGET_COMPATIBILITY=1.8

to

SOURCE_COMPATIBILITY=11
TARGET_COMPATIBILITY=11

[eduarddrenth]

can you perhaps approve, so I can verify the tests succeed with my last commits?

[eduarddrenth]

I don't know how to fix the test run issues, servlet runs fine on payara 6. Perhaps lower servlet spec for better compatibility?

[eduarddrenth]

solution might be:

• use springframework 6.0.2 in unit testing
• add gradle config to run tests with java 17 (required by springframework 6)

Or redesign the test env (large impact I suspect) or skip tests (undesirable)

[oliemansm]

@eduarddrenth Since this has quite significant impact I've started a poll for this to get some insights. If the poll does not provide a clear direction or doesn't have that many votes I'll make a decision. See #487

[eduarddrenth]

@eduarddrenth Since this has quite significant impact I've started a poll for this to get some insights. If the poll does not provide a clear direction or doesn't have that many votes I'll make a decision. See #487

good idea! voted for 17 myself

[eduarddrenth]

Running tests using jdk 17 with

SOURCE_COMPATIBILITY=17
TARGET_COMPATIBILITY=17

and

    testImplementation 'org.springframework:spring-test:6.0.2'
    testRuntimeOnly 'org.springframework:spring-web:6.0.2'

succeeds

[oliemansm]

@eduarddrenth Can you update your PR with the changes you've confirmed work locally? Can you sync in my latest push to master as well? That should update the github actions to work with jdk 17 only.

[eduarddrenth]

fixed some tests

[oliemansm]

@eduarddrenth I made some changes but couldn't push them to your branch, so created and merged in a separate pr. Closing this one now.

[eduarddrenth]

Great!