Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeated directives are ignored #615

Closed
prgood opened this issue Jan 6, 2022 · 2 comments
Closed

Repeated directives are ignored #615

prgood opened this issue Jan 6, 2022 · 2 comments
Labels

Comments

@prgood
Copy link

prgood commented Jan 6, 2022

Description

The graphql-java library support repeatable directives as we can see here: graphql-java/graphql-java#1763
Example:
directive @Min(value : Int! = 0, country : String) repeatable on ARGUMENT_DEFINITION | INPUT_FIELD_DEFINITION

But "SchemaParser" is reading only the first repeated directive like in the example below we got only the first directive triggered:

type Query {
    test(
        minField: Int @Min(value : 30, country: "BR"),   @Min(value : 10, country: "UK")
    )
}

I think this line is part of the issue:

if (!names.contains(directive.name)) {

Expected behavior

When more the one of a"repeatable" directive is applied to a field, all repeated directives should be processed.

Actual behavior

Only the first directive is been processed.

Steps to reproduce the bug

  1. Define a directive as "repeatable" like the example above.
  2. Apply this directive more then once to a single field.
  3. All directives should run
@oryan-block
Copy link
Collaborator

Fix with #663

@jimartinmoreno
Copy link

I'm experiencing the same problem with version 11.1.0 and 12.0. Is this feature available in any kickstart version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants