feat: .nonNull / .nullable chaining, additional cleanup #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5e2e471.
tgriesser
commented
Nov 22, 2020
| @@ -1,5 +1,5 @@ | |||
| --- | |||
| title: list / nonNull / nullable | |||
| title: list / nonNull | |||
There was a problem hiding this comment.
Since we default to nonNullDefault: false, I wanted to avoid advertising nullable in the top-level API. It's a bit of an antipattern.
Codecov Report
@@ Coverage Diff @@
## develop #655 +/- ##
===========================================
+ Coverage 93.84% 94.19% +0.34%
===========================================
Files 42 44 +2
Lines 2744 2806 +62
Branches 629 648 +19
===========================================
+ Hits 2575 2643 +68
+ Misses 167 161 -6
Partials 2 2 |
This was referenced Nov 23, 2020
tgriesser
changed the base branch from
feat/null-list-chaining-api
to
develop
Weakky
reviewed
Nov 23, 2020
Weakky
reviewed
Nov 23, 2020
Weakky
reviewed
Nov 23, 2020
Weakky
reviewed
Nov 23, 2020
tgriesser
changed the title
9renpoto
pushed a commit
to 9renpoto/schema
that referenced
this pull request
Dec 4, 2020
…s#655) - Fixes SDL conversion - Defer wrapping until types are built - Supports GraphQL types anywhere that a type can be used, wrapped, etc. - Split out the wrapping, w/ `finalizeWrapping` helper which adds in the `NonNull` to the list as needed - Make `nonNull(nonNull(T))` & `nullable(nullable(T))` no-op for simplicity - Change: `nullable(nonNull(T))` will undo the `nonNull` - Properly type-check's `subscriptionType` by passing `Event` generic properly - Adds `declarativeWrappingPlugin` for previous `nullable` / `list` behavior Co-authored-by: Flavian DESVERNE <flavian.desverne@epitech.eu>
imgbot bot
pushed a commit
to 9renpoto/schema
that referenced
this pull request
Dec 4, 2020
…s#655) - Fixes SDL conversion - Defer wrapping until types are built - Supports GraphQL types anywhere that a type can be used, wrapped, etc. - Split out the wrapping, w/ `finalizeWrapping` helper which adds in the `NonNull` to the list as needed - Make `nonNull(nonNull(T))` & `nullable(nullable(T))` no-op for simplicity - Change: `nullable(nonNull(T))` will undo the `nonNull` - Properly type-check's `subscriptionType` by passing `Event` generic properly - Adds `declarativeWrappingPlugin` for previous `nullable` / `list` behavior Co-authored-by: Flavian DESVERNE <flavian.desverne@epitech.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finalizeWrappinghelper which adds in theNonNullto the list as needednonNull(nonNull(T))&nullable(nullable(T))no-op for simplicitynullable(nonNull(T))will undo thenonNullsubscriptionTypeby passingEventgeneric properlydeclarativeWrappingPluginfor previousnullable/listbehavior