Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get response headers even with 4xx return code #367

Conversation

leszekhanusz
Copy link
Collaborator

  • In AIOHTTPTransport, save the response headers before sending a TransportServerError
  • Add tests for this for AIOHTTPTransport and RequestsHTTPTransport (already working)

Related: #366

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (86d253b) compared to base (e53b168).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #367   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        24    -2     
  Lines         2250      2215   -35     
=========================================
- Hits          2250      2215   -35     
Impacted Files Coverage Δ
gql/transport/aiohttp.py 100.00% <100.00%> (ø)
gql/utils.py
gql/__init__.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@leszekhanusz leszekhanusz merged commit 5e47f5f into graphql-python:master Nov 7, 2022
@leszekhanusz leszekhanusz deleted the feature_get_response_headers_with_4xx_return_code branch November 7, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant