Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust aiohttp pin #425

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Adjust aiohttp pin #425

merged 1 commit into from
Jul 26, 2023

Conversation

cdce8p
Copy link
Contributor

@cdce8p cdce8p commented Jul 25, 2023

Update aiohttp pin to allow versions other then 3.8.x with <4.

Background: It looks like aiohttp will add support for Python 3.12 only in 3.9.0. By pinning <3.9 this packages unnecessarily constraints what versions downstream packages or apps can install. With semantic versioning everything up to <4.0 should be backwards compatible.

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f7fcaf6) 100.00% compared to head (6ba05de) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #425   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines         2388      2388           
=========================================
  Hits          2388      2388           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leszekhanusz
Copy link
Collaborator

The 3.9 aiohttp version is not released yet, but they sure are supposed to follow semver so we might allow it.

But why did you want this change now before the version is available? Why not wait that the 3.9 version is available and verify that all the tests are working before doing this change?

@cdce8p
Copy link
Contributor Author

cdce8p commented Jul 26, 2023

The 3.9 aiohttp version is not released yet, but they sure are supposed to follow semver so we might allow it.

But why did you want this change now before the version is available? Why not wait that the 3.9 version is available and verify that all the tests are working before doing this change?

I've already starting testing Python 3.12 for Home Assistant. Since we have a lot (>880) direct dependencies, it's quite common that a new Python version doesn't work initially. The earlier we can fix potential issues, the easier it will be to fully support it later on once 3.12 is released.

Just for reference, this is the aiohttp PR aio-libs/aiohttp#7400 which added build support for Python 3.12. It was only tagged to be backported to 3.9 not 3.8. That's why I already checked which of our dependencies aren't compatible.

@cdce8p cdce8p mentioned this pull request Jul 26, 2023
32 tasks
@leszekhanusz leszekhanusz merged commit f96ae5c into graphql-python:master Jul 26, 2023
15 checks passed
@leszekhanusz
Copy link
Collaborator

This is now available in pre-release 3.5.0b5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants