Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop gql aiohttp extra #84

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Drop gql aiohttp extra #84

merged 1 commit into from
Oct 6, 2023

Conversation

cdce8p
Copy link
Contributor

@cdce8p cdce8p commented Oct 6, 2023

Drop the gql[aiohttp] extra.

Background
gql 3.4.1 pins aiohttp<3.9. This isn't an issue now as the current version is 3.8.5. However 3.9.0 is expected to be released this weekend with support for Python 3.12. Thus the pin in gql would ultimately block the aiohttp update in Home Assistant.

https://github.com/graphql-python/gql/blob/v3.4.1/setup.py#L41

I've already contributed a patch upstream. Unfortunately though the release of gql is blocked currently. Thus the best option to address it is by removing the extra requirement here. aiohttp still is an explicit dependency, so there shouldn't be any issues.

@cdce8p cdce8p mentioned this pull request Oct 6, 2023
32 tasks
@dknowles2
Copy link
Owner

LGTM, thanks!

(I'm always shocked that Home Assistant dependencies work at all. What a mess.)

@dknowles2 dknowles2 merged commit cb69c63 into dknowles2:main Oct 6, 2023
3 checks passed
@cdce8p cdce8p deleted the drop-gql-aiohttp branch October 6, 2023 12:17
@cdce8p
Copy link
Contributor Author

cdce8p commented Oct 6, 2023

(I'm always shocked that Home Assistant dependencies work at all. What a mess.)

It's a lot of work and some magic, especially for new Python releases 😅

@dknowles2 Could you create a new release? It would be awesome if we could upstream the change here to Home Assistant before the aiohttp update this weekend.

@dknowles2
Copy link
Owner

(I'm always shocked that Home Assistant dependencies work at all. What a mess.)

It's a lot of work and some magic, especially for new Python releases 😅

@dknowles2 Could you create a new release? It would be awesome if we could upstream the change here to Home Assistant before the aiohttp update this weekend.

Sure. Kicked it off here: https://github.com/dknowles2/pydrawise/releases/tag/2023.10.0

Should get published to pypi shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants