Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use choice keys, not descriptions, for enums #19

Closed
morgante opened this issue Oct 12, 2016 · 0 comments · Fixed by #23
Closed

Use choice keys, not descriptions, for enums #19

morgante opened this issue Oct 12, 2016 · 0 comments · Fixed by #23

Comments

@morgante
Copy link
Contributor

Currently, the automatically generated choices for Django fields correspond to the text labels passed in not the keys.

This is problematic because changing labels in the future would lead to all your enum values being updated. It's also contrary to what I would expect as a user.
@morgante morgante changed the title Use choice keys, not descriptions for enums Use choice keys, not descriptions, for enums Oct 12, 2016
morgante added a commit to morgante/graphene-django that referenced this issue Oct 14, 2016
@morgante
Fix graphql-python#19 by using choice keys as enum keys, not choice d…
8351143 
…escriptions
morgante added a commit to morgante/graphene-django that referenced this issue Oct 14, 2016
@morgante
Fix graphql-python#19 by using choice keys as enum keys, not choice d…
5ad21f1 
…escriptions
@morgante morgante mentioned this issue Oct 14, 2016
Merged
syrusakbary added a commit that referenced this issue Oct 15, 2016
@syrusakbary
Merge pull request #23 from morgante/fix_choice_enums
3a9ffba 
Fix #19 by using choice keys as enum keys, not choice descriptions
Hispar added a commit to Hispar/graphene-django that referenced this issue May 24, 2019
@Hispar
Merge pull request graphql-python#19 from mrmilu/enhancement/test-ref…
e1229d0 
…actor

Restore pytest and improve coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #19 by using choice keys as enum keys, not choice descriptions morgante/graphene-django
1 participant
@morgante