Fix #19 by using choice keys as enum keys, not choice descriptions #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good point! I will merge and then fix the tests 👍 |
LilyFoote
reviewed
Nov 15, 2016
| try: | ||
| assert_valid_name(name) | ||
| except AssertionError: | ||
| name = "A_%s" % name |
There was a problem hiding this comment.
This could break badly if python is run with optimisations on (python -O) because that disables assert statements, as used in assert_valid_name. The possible fixes are to update assert_valid_name to raise a different exception (ValueError probably) or to add a parallel function to assert_valid_name for use like this.
Hispar
added a commit
to Hispar/graphene-django
that referenced
this pull request
May 24, 2019
…string Graphiql no querystring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #19 so that only the keys (as used in the database) for choice enums. This is superior because descriptions might change over time but you don't want the underlying keys to change.
It also auto-prefixes the keys with "A_" if they would otherwise violate ENUM rule names.