Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #914
This fixes the issue raised and adds a test to prevent future regressions.
Note that this slightly changes to public api of
juniper::Object
's:add_field
will now check if a new field exists and is an object, and in that case merge the objects keys instead of replacing the old object.It might also make sense to not return anything from that function (which is a breaking change of the public interface, but seems to compile without modification to the existing uses in the juniper crate, I think the behavior was originally copied from
std::collections::HashMap
).