Fix "Switch to HashMap for the internal representation of object fields (#872)" #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you think it makes sense to add a test for the partial eq? (I saw that it’s derived now; but having a test like this might prevent a similar regression in a future refactor; especially seeing the trait being implemented correctly is so important for a lot of the other existing tests) |
|
@dyedgreen don't think so. I think the test has sense only if the code written manually. So, it should've been added when manual implementation was added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#872 has introduced broken
Object::partial_eqimplementation therefore rendering some tests useless.Also,
Objectfield merging functionality was completely removed in that PR for some reason, which should have resulted in failing tests but didn't.#914 was caused by this and #915 partially resolved the issue by implementing the same thing in the different place.
This PR rollbacks the
Objectimplementation to its original state, switches the underlying type toHashMapand (hopefully) breaks nothing else.