perf: call and reuse cacheKeyFn only when it is needed (if caching)

graphql · Jun 9, 2023 · 965c884 · 965c884
1 parent d336bd1
commit 965c884
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/index.js b/src/index.js
@@ -81,10 +81,11 @@ class DataLoader<K, V, C = K> {
 
     const batch = getCurrentBatch(this);
     const cacheMap = this._cacheMap;
-    const cacheKey = this._cacheKeyFn(key);
+    let cacheKey;
 
     // If caching and there is a cache-hit, return cached Promise.
     if (cacheMap) {
+      cacheKey = this._cacheKeyFn(key);
       const cachedPromise = cacheMap.get(cacheKey);
       if (cachedPromise) {
         const cacheHits = batch.cacheHits || (batch.cacheHits = []);