Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typings and test for priming with promise #252

Merged
merged 4 commits into from Jul 4, 2022

Conversation

LinusU
Copy link
Contributor

@LinusU LinusU commented Sep 15, 2020

This adds typings (for both Flow & TypeScript) and adds a test for priming the cache with a Promise

Fixes #235

@LinusU
Copy link
Contributor Author

LinusU commented Sep 15, 2020

@leebyron I've previously signed the CLA for React Native, let me know if there is anything else that is needed to get this landed ☺️

@LinusU
Copy link
Contributor Author

LinusU commented Sep 24, 2020

ping @leebyron, is there anything else I can do to facilitate this getting merged?

@LinusU
Copy link
Contributor Author

LinusU commented Sep 30, 2020

ping @Caerbannog, are you able to land PRs into this repo? Anything that is needed from my end? ☺️

@LinusU
Copy link
Contributor Author

LinusU commented Dec 14, 2020

ping @leebyron would love to get this in, as we still need to use @ts-ignore to use this API 😅

@LinusU
Copy link
Contributor Author

LinusU commented May 14, 2021

@benjie I saw that you approved another pull request, would be able to take a look at this one as well? ☺️

@benjie
Copy link
Member

benjie commented May 14, 2021

No, sorry.

@LinusU
Copy link
Contributor Author

LinusU commented May 25, 2021

ping @leebyron I would be so happy if this could land 🤩

@LinusU
Copy link
Contributor Author

LinusU commented Aug 6, 2021

@leebyron anything I can do to move this forward? Would love to get this released ☺️

@LinusU
Copy link
Contributor Author

LinusU commented Mar 2, 2022

@IvanGoncharov I saw that you merged another pull request, would be able to take a look at this one as well? ☺️

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 12, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: LinusU / name: Linus Unnebäck (0a1ea89)
  • ✅ login: saihaj / name: Saihajpreet Singh (786008f)

@saihaj
Copy link
Member

saihaj commented Apr 12, 2022

Hey @LinusU can you please sign the CLA?

@LinusU
Copy link
Contributor Author

LinusU commented May 30, 2022

@saihaj awesome to see progress on this! I've signed the CLA now 🚀

@saihaj
Copy link
Member

saihaj commented Jul 4, 2022

sorry for long wait @LinusU

@saihaj saihaj merged commit fae38f1 into graphql:main Jul 4, 2022
@LinusU
Copy link
Contributor Author

LinusU commented Jul 5, 2022

Thank you for merging! 🙏

@LinusU LinusU deleted the prime-with-promise branch July 5, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQUEST] Prime by promise
3 participants