This repository has been archived by the owner on Mar 20, 2023. It is now read-only.
Disable GET for non-query operations #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leebyron
force-pushed
the
safe-get
branch
2 times, most recently
from
4c2b365
to
779b354
Compare
leebyron
force-pushed
the
safe-get
branch
2 times, most recently
from
f715550
to
17aa67b
Compare
| * Helper function to produce an operation AST given a document and an | ||
| * operation name. | ||
| */ | ||
| function getOperation(documentAST: Object, operationName: ?string): ?Object { |
There was a problem hiding this comment.
Should this live in graphql-js somewhere?
There was a problem hiding this comment.
I had the same thought. I'll do that but give it some time to replace this usage to avoid bleeding-edge dependency-hell
There was a problem hiding this comment.
|
This looks good, ship it. |
This fixes #17 by disabling GET requests for non-query operations. However GraphiQL may still be presented for these GET queries, but the query will just not be immediately issued, allowing for exploration of mutations. I considered adding an option flag to enable mutations on GET, but decided that this edge case is sufficiently rare that we should only introduce it when there is a clear and compelling use case so that we get the API correct.
leebyron
added a commit
that referenced
this pull request
Oct 1, 2015
Disable GET for non-query operations
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #17 by disabling GET requests for non-query operations. However GraphiQL may still be presented for these GET queries, but the query will just not be immediately issued, allowing for exploration of mutations.
I considered adding an option flag to enable mutations on GET, but decided that this edge case is sufficiently rare that we should only introduce it when there is a clear and compelling use case so that we get the API correct.