Skip to content
This repository has been archived by the owner on Mar 20, 2023. It is now read-only.

Set 500 status code when graphql returns a result with no data #419

Merged
merged 2 commits into from
Feb 19, 2018

Conversation

JontyUsborne
Copy link
Contributor

Fix #417 by returning a 500 HTTP status code when query variables are invalidated during execution (or whenever graphql returns a result with no data property)

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@IvanGoncharov IvanGoncharov merged commit 24ac2f1 into graphql:master Feb 19, 2018
@IvanGoncharov
Copy link
Member

@JontyUsborne Thank you for the PR and especially for the test 👍
I will try to push new release today 📦

@JontyUsborne
Copy link
Contributor Author

Great. Glad you got commit rights, thanks for all your help @IvanGoncharov!

@IvanGoncharov
Copy link
Member

This PR included in 0.6.12 📦
More details in Released notes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants