Skip to content
This repository has been archived by the owner on Mar 20, 2023. It is now read-only.

Add missing parameter types #630

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Add missing parameter types #630

merged 1 commit into from
Jun 11, 2020

Conversation

danielrearden
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Jun 10, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 99.639% when pulling 15ae54e on danielrearden:parameter-types into b2f7297 on graphql:master.

@danielrearden
Copy link
Collaborator Author

@IvanGoncharov FWIW, I turned on the flowtype/require-parameter-type rule to help identify the missing parameter types, but I think that generates way too many false positives to enable permanently, even as a warning.

@danielrearden danielrearden force-pushed the parameter-types branch 2 times, most recently from 73d4f97 to 0fec9d6 Compare June 11, 2020 00:31
@danielrearden danielrearden marked this pull request as draft June 11, 2020 00:41
@danielrearden danielrearden force-pushed the parameter-types branch 2 times, most recently from 5a096f3 to bc78694 Compare June 11, 2020 01:08
@danielrearden danielrearden marked this pull request as ready for review June 11, 2020 01:16
@danielrearden danielrearden force-pushed the parameter-types branch 3 times, most recently from 596f664 to 7834ced Compare June 11, 2020 13:13
@IvanGoncharov
Copy link
Member

@danielrearden Left a couple of comments and everything else looks great 👍

@IvanGoncharov IvanGoncharov merged commit 4140325 into graphql:master Jun 11, 2020
@danielrearden danielrearden deleted the parameter-types branch June 11, 2020 19:32
@IvanGoncharov IvanGoncharov added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Jul 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IvanGoncharov IvanGoncharov IvanGoncharov left review comments

Assignees
No one assigned
Labels
PR: polish 💅 PR doesn't change public API or any observed behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danielrearden @coveralls @IvanGoncharov