This repository has been archived by the owner on Mar 20, 2023. It is now read-only.
Fix RequestInfo typings #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielrearden
force-pushed
the
fix-request-info
branch
from
dc09163
to
ab78883
Compare
danielrearden
force-pushed
the
fix-request-info
branch
from
ab78883
to
2c73471
Compare
danielrearden
commented
Jun 27, 2020
| @@ -171,7 +171,7 @@ export type RequestInfo = {| | |||
| /** | |||
| * The result of executing the operation. | |||
| */ | |||
| result: ExecutionResult | null, | |||
| result: ExecutionResult, | |||
There was a problem hiding this comment.
Removed the null here because result could never be null (see here)
There was a problem hiding this comment.
Thanks for comment 馃憤
It's very helpful.
IvanGoncharov
added
the
PR: bug fix 馃悶
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two other properties that I missed as well 馃槗