This repository has been archived by the owner on Mar 20, 2023. It is now read-only.
Improve TS type coverage #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanGoncharov
added
the
PR: polish 💅
src/index.ts
Outdated
| @@ -466,8 +465,7 @@ export async function getGraphQLParams( | |||
| request: Request, | |||
| ): Promise<GraphQLParams> { | |||
| // `url` is always defined for IncomingMessage coming from http.Server | |||
| // eslint-disable-next-line @typescript-eslint/no-non-null-assertion | |||
| const urlData = new URLSearchParams(request.url!.split('?')[1]); | |||
| const urlData = new URLSearchParams(request.url?.split('?')[1]); | |||
There was a problem hiding this comment.
request.url should always be defined in the context we're using it, so I'm not sure how the coverage isn't dropping with the use of conditional chaining here :/
There was a problem hiding this comment.
@danielrearden Thanks, corrected Request type to reflect that.
| @@ -6,12 +6,9 @@ import querystring from 'querystring'; | |||
| import getBody from 'raw-body'; | |||
| import httpError from 'http-errors'; | |||
| import contentType from 'content-type'; | |||
| import type { ParsedMediaType } from 'content-type'; | |||
There was a problem hiding this comment.
dang should have added a FIXME before, thanks
junminstorage
pushed a commit
to junminstorage/express-graphql
that referenced
this pull request
Aug 14, 2020
This was referenced Mar 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.