This repository has been archived by the owner on Mar 20, 2023. It is now read-only.
Revert "Allow custom handling of runtime query errors" #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 43ba606.
|
How does #696 violate the linked spec? |
|
I believe the authors of the library are misreading the spec:
My response contains a null data entry as described, and yet it still corrupts the status code. Can we revert this? It's pretty annoying to see the community rally behind something with consensus, only for it to be reverted based seemingly on principle, and without addressing the practical concerns of the community. |
|
Apollo-Client cannot be used with the 500 status code !!!!!!!!!! FIX THIS ASAP! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #696
we have to be following the transport spec error codes:
https://github.com/graphql/graphql-over-http/blob/master/spec/GraphQLOverHTTP.md#status-codes